codinux
/
BankingClient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

As messageLogWithoutSensitiveData gets called for sure removing sensitive data upfront now

This commit is contained in:
dankito 2021-11-13 15:27:12 +01:00
parent e87adc8499
commit 6d48382a7e
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fints4k/src/commonMain/kotlin/net/dankito/banking/fints/log/MessageLogCollector.kt
View File

@ -30,7 +30,7 @@ open class MessageLogCollector {
// in either case remove sensitive data after response is parsed as otherwise some information like account holder name and accounts may is not set yet on BankData // in either case remove sensitive data after response is parsed as otherwise some information like account holder name and accounts may is not set yet on BankData
open val messageLogWithoutSensitiveData: List<MessageLogEntry> open val messageLogWithoutSensitiveData: List<MessageLogEntry>
get() = messageLog.map { MessageLogEntry(it.type, safelyRemoveSensitiveDataFromMessage(it.message, it.context.bank), it.context, it.time) } get() = ArrayList(messageLog)
protected open val stackTraceHelper = StackTraceHelper() protected open val stackTraceHelper = StackTraceHelper()
@ -39,9 +39,9 @@ open class MessageLogCollector {
open fun addMessageLog(type: MessageLogEntryType, message: String, context: MessageContext) { open fun addMessageLog(type: MessageLogEntryType, message: String, context: MessageContext) {
val messageToLog = createMessage(type, prettyPrintHbciMessage(message), context, true) val messageToLog = createMessage(type, prettyPrintHbciMessage(message), context, true)
messageLog.add(MessageLogEntry(type, messageToLog, context)) addMessageLogEntry(type, messageToLog, context)
log.debug { messageToLog } log.info { messageToLog }
} }
open fun logError(loggingClass: KClass<*>, message: String, context: MessageContext, e: Exception? = null) { open fun logError(loggingClass: KClass<*>, message: String, context: MessageContext, e: Exception? = null) {
@ -56,7 +56,13 @@ open class MessageLogCollector {
val errorStackTrace = if (e != null) NewLine + getStackTrace(e) else "" val errorStackTrace = if (e != null) NewLine + getStackTrace(e) else ""
messageLog.add(MessageLogEntry(type, messageToLog + errorStackTrace, context)) addMessageLogEntry(type, messageToLog + errorStackTrace, context)
}
protected open fun addMessageLogEntry(type: MessageLogEntryType, message: String, context: MessageContext) {
val withoutSensitiveData = safelyRemoveSensitiveDataFromMessage(message, context.bank)
messageLog.add(MessageLogEntry(type, withoutSensitiveData, context))
} }