codinux
/
BankingClient
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed (in a bit ugly way) that iOS 14 crashes if after pressing back button any changes to list (form) are don't and therefore count cells changes

This commit is contained in:
dankito 2020-09-28 00:29:18 +02:00
parent 34d5877419
commit a518960070
1 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
ui/BankingiOSApp/BankingiOSApp/ui/dialogs/TransferMoneyDialog.swift
View File

@ -51,6 +51,8 @@ struct TransferMoneyDialog: View {
@State private var didJustCorrectEnteredValue = false
@State private var doNotDoAnyChangesToUiAnymore = false
private var account: IBankAccount? {
if (self.selectedAccountIndex < self.accountsSupportingTransferringMoney.count) {
@ -118,7 +120,7 @@ struct TransferMoneyDialog: View {
Section {
LabelledUIKitTextField(label: "Recipient Name", text: $recipientName, focusOnStart: true, focusNextTextFieldOnReturnKeyPress: true,
isFocusedChanged: recipientNameisFocusedChanged, actionOnReturnKeyPress: handleReturnKeyPress, textChanged: enteredRecipientNameChanged)
isFocusedChanged: recipientNameIsFocusedChanged, actionOnReturnKeyPress: handleReturnKeyPress, textChanged: enteredRecipientNameChanged)
.padding(.bottom, 0)
recipientNameValidationResult.map { validationError in
@ -133,7 +135,7 @@ struct TransferMoneyDialog: View {
}
LabelledUIKitTextField(label: "Recipient IBAN", text: $recipientIban, autocapitalizationType: .allCharacters, focusNextTextFieldOnReturnKeyPress: true, isFocusedChanged: validateRecipientIbanOnFocusLost,
actionOnReturnKeyPress: handleReturnKeyPress, textChanged: recipientIbanisFocusedChanged)
actionOnReturnKeyPress: handleReturnKeyPress, textChanged: enteredRecipientIbanChanged)
recipientIbanValidationResult.map { validationError in
ValidationLabel(validationError)
@ -213,6 +215,7 @@ struct TransferMoneyDialog: View {
.alert(message: $transferMoneyResponseMessage)
.fixKeyboardCoversLowerPart()
.showNavigationBarTitle("Transfer Money Dialog Title")
.customNavigationBarBackButton(cancelPressed)
}
@ -236,7 +239,11 @@ struct TransferMoneyDialog: View {
}
private func recipientNameisFocusedChanged(_ isFocused: Bool) {
private func recipientNameIsFocusedChanged(_ isFocused: Bool) {
if doNotDoAnyChangesToUiAnymore {
return
}
if isFocused == false {
validateRecipientNameOnFocusLost()
@ -283,13 +290,17 @@ struct TransferMoneyDialog: View {
}
private func recipientIbanisFocusedChanged(_ enteredIban: String) {
private func enteredRecipientIbanChanged(_ enteredIban: String) {
validateField($recipientIban, $recipientIbanValidationResult, $isValidRecipientIbanEntered) { inputValidator.validateIbanWhileTyping(ibanToTest: enteredIban) }
tryToGetBicFromIban(enteredIban)
}
private func validateRecipientIbanOnFocusLost(_ isFocused: Bool) {
if doNotDoAnyChangesToUiAnymore {
return
}
if isFocused == false {
validateRecipientIbanOnFocusLost()
}
@ -357,10 +368,11 @@ struct TransferMoneyDialog: View {
}
private func validateReference() {
validateField($reference, $referenceValidationResult, $isValidReferenceEntered) { inputValidator.validateReference(referenceToTest: self.reference) }
validateField($reference, $referenceValidationResult, $isValidReferenceEntered) { inputValidator.validateReference(referenceToTest: self.reference) }
}
private func validateField(_ newValue: Binding<String>, _ validationResult: Binding<ValidationResult?>, _ isValidValueEntered: Binding<Bool>, _ validateValue: () -> ValidationResult) {
if (didJustCorrectEnteredValue == false) {
let fieldValidationResult = validateValue()
@ -407,7 +419,7 @@ struct TransferMoneyDialog: View {
if (response.successful) {
self.transferMoneyResponseMessage = Message(message: Text("Successfully transferred \(data.amount) \("€") to \(data.recipientName)."), primaryButton: .ok {
self.presentation.wrappedValue.dismiss()
self.closeDialog()
})
}
else if response.userCancelledAction == false {
@ -415,6 +427,18 @@ struct TransferMoneyDialog: View {
}
}
private func cancelPressed() {
// ugly, i know. iOS 14 crashes when after pressing cancel e.g. due to validation count cells changes -> don't do any changes or validation anymore after cancel navigation bar button has been pressed
doNotDoAnyChangesToUiAnymore = true
closeDialog()
}
private func closeDialog() {
presentation.wrappedValue.dismiss()
}
}
struct TransferMoneyDialog_Previews: PreviewProvider {