codinux
/
Bankmeister
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed using Composable's scope instead of GlobalScope

This commit is contained in:
dankito 2024-09-27 00:12:35 +02:00
parent e3a6cd7df2
commit d12cb7269b
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
composeApp/src/commonMain/kotlin/net/codinux/banking/ui/composables/tan/ChipTanFlickerCodeView.kt
View File

@ -44,6 +44,8 @@ fun ChipTanFlickerCodeView(flickerCode: FlickerCode, textColor: Color = Color.Bl
var step by remember { mutableStateOf(Step(Bit.High, Bit.High, Bit.High, Bit.High, Bit.High)) } var step by remember { mutableStateOf(Step(Bit.High, Bit.High, Bit.High, Bit.High, Bit.High)) }
val coroutineScope = rememberCoroutineScope()
fun setSize(width: Dp, height: Dp, spaceBetween: Dp) { fun setSize(width: Dp, height: Dp, spaceBetween: Dp) {
stripesWidth = width stripesWidth = width
@ -157,7 +159,7 @@ fun ChipTanFlickerCodeView(flickerCode: FlickerCode, textColor: Color = Color.Bl
DisposableEffect(animator) { DisposableEffect(animator) {
animator.setFrequency(frequency) animator.setFrequency(frequency)
animator.animateFlickerCode(flickerCode) { animator.animateFlickerCode(flickerCode, coroutineScope) {
step = it step = it
} }

4
composeApp/src/commonMain/kotlin/net/codinux/banking/ui/service/tan/FlickerCodeAnimator.kt
View File

@ -26,11 +26,11 @@ class FlickerCodeAnimator {
fun animateFlickerCode(flickerCode: FlickerCode, showStep: (Step) -> Unit) { // TODO: find better coroutine scope fun animateFlickerCode(flickerCode: FlickerCode, scope: CoroutineScope , showStep: (Step) -> Unit) {
stop() // stop may still running previous animation stop() // stop may still running previous animation
flickerCode.parsedDataSet?.let { parsedDataSet -> flickerCode.parsedDataSet?.let { parsedDataSet ->
animationJob = GlobalScope.launch(Dispatchers.Default) { animationJob = scope.launch(Dispatchers.Default) {
val steps = FlickerCodeStepsCalculator().calculateSteps(parsedDataSet) val steps = FlickerCodeStepsCalculator().calculateSteps(parsedDataSet)
calculateAnimation(steps, showStep) calculateAnimation(steps, showStep)