codinux
/
fints4k
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed unnecessary steps from setPasswords()

This commit is contained in:
dankito 2020-10-16 15:49:24 +02:00
parent 3da594b846
commit 08b7eb28a7
1 changed files with 15 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ui/BankingiOSApp/BankingiOSApp/Security/AuthenticationService.swift
View File

@ -18,6 +18,7 @@ class AuthenticationService {
static private let IV = "drowssapdrowssap" // length = 16
private let biometricAuthenticationService = BiometricAuthenticationService()
private let persistence: IBankingPersistence
@ -210,23 +211,13 @@ class AuthenticationService {
@discardableResult
private func setPasswords(_ useBiometricAuthentication: Bool, _ newLoginPassword: String?) -> Bool {
do {
let passwordItem = createDefaultPasswordKeychainItem(useBiometricAuthentication)
deleteDefaultPassword(useBiometricAuthentication) // TODO: needed?
let currentPassword = try? passwordItem.readPassword()
var databasePassword = ""
try? passwordItem.deleteItem()
var databasePassword = currentPassword ?? ""
if let currentPassword = currentPassword, let encryped = encrypt(currentPassword) {
try passwordItem.savePassword(encryped)
}
else {
if let newDefaultPassword = createNewDefaultPassword(useBiometricAuthentication) {
if let newDefaultPassword = createAndSetDefaultPassword(useBiometricAuthentication) {
databasePassword = newDefaultPassword
}
}
if let newLoginPassword = newLoginPassword {
setLoginPassword(newLoginPassword)
@ -234,15 +225,10 @@ class AuthenticationService {
}
return persistence.changePassword(newPassword: map(databasePassword))
} catch {
NSLog("Could not save default password: \(error)")
}
return false
}
@discardableResult
private func createNewDefaultPassword(_ useBiometricAuthentication: Bool) -> String? {
private func createAndSetDefaultPassword(_ useBiometricAuthentication: Bool) -> String? {
do {
let newDefaultPassword = generateRandomPassword(30)