Created FinTsServerAddressFinder with BankListCreator to easily retrieve a FinTS server address to a bank code

SampleApplications/AndroidApp/src/main/java/net/codinux/banking/fints4k/android/FirstFragment.kt

@@ -47,7 +47,7 @@ class FirstFragment : Fragment() {
         }
 
         // TODO: set your credentials here
-        presenter.retrieveAccountData("", "", "", "") { response ->
+        presenter.retrieveAccountData("", "", "") { response ->
             response.customerAccount?.let { customer ->
                 accountTransactionsAdapter.items = customer.accounts.flatMap { it.bookedTransactions }
             }

SampleApplications/AndroidApp/src/main/java/net/codinux/banking/fints4k/android/Presenter.kt

@@ -34,9 +34,9 @@ open class Presenter {
 
 
 
-    open fun retrieveAccountData(bankCode: String, customerId: String, pin: String, finTs3ServerAddress: String, retrievedResult: (GetAccountDataResponse) -> Unit) {
+    open fun retrieveAccountData(bankCode: String, loginName: String, password: String, retrievedResult: (GetAccountDataResponse) -> Unit) {
         GlobalScope.launch(Dispatchers.IO) {
-            val response = fintsClient.getAccountData(GetAccountDataParameter(bankCode, customerId, pin, finTs3ServerAddress))
+            val response = fintsClient.getAccountData(GetAccountDataParameter(bankCode, loginName, password))
             log.info("Retrieved response from ${response.customerAccount?.bankName} for ${response.customerAccount?.customerName}")
 
             withContext(Dispatchers.Main) {

SampleApplications/WebApp/src/main/kotlin/AccountTransactionsView.kt

@@ -27,7 +27,7 @@ class AccountTransactionsView(props: AccountTransactionsViewProps) : RComponent<
     // due to CORS your bank's servers can not be requested directly from browser -> set a CORS proxy url in main.kt
     // TODO: set your credentials here
     GlobalScope.launch {
-      props.presenter.retrieveAccountData("", "", "", "") { response ->
+      props.presenter.retrieveAccountData("", "", "") { response ->
         response.customerAccount?.let { customer ->
           val balance = customer.accounts.sumOf { it.balance?.amount?.string?.replace(',', '.')?.toDoubleOrNull() ?: 0.0 } // i know, double is not an appropriate data type for amounts
 

SampleApplications/WebApp/src/main/kotlin/Presenter.kt

@@ -32,9 +32,9 @@ open class Presenter {
   }
 
 
-  open fun retrieveAccountData(bankCode: String, customerId: String, pin: String, finTs3ServerAddress: String, retrievedResult: (GetAccountDataResponse) -> Unit) {
+  open fun retrieveAccountData(bankCode: String, loginName: String, password: String, retrievedResult: (GetAccountDataResponse) -> Unit) {
     GlobalScope.launch(Dispatchers.Unconfined) {
-      val response = fintsClient.getAccountData(GetAccountDataParameter(bankCode, customerId, pin, finTs3ServerAddress))
+      val response = fintsClient.getAccountData(GetAccountDataParameter(bankCode, loginName, password))
 
       log.info("Retrieved response from ${response.customerAccount?.bankName} for ${response.customerAccount?.customerName}")
 

SampleApplications/iOSApp/fints4k iOS/fints4k iOS/ContentView.swift

@@ -51,7 +51,7 @@ struct ContentView: View {
     
     private func retrieveTransactions() {
         // TODO: set your credentials here
-        self.presenter.getAccountData("", "", "", "", self.handleGetAccountDataResponse)
+        self.presenter.getAccountData("", "", "", self.handleGetAccountDataResponse)
     }
     
     private func handleGetAccountDataResponse(_ response: GetAccountDataResponse) {

fints4k/src/commonMain/kotlin/net/dankito/banking/client/model/CustomerAccount.kt

@@ -11,7 +11,7 @@ open class CustomerAccount(
     override var bankCode: String,
     override var loginName: String,
     override var password: String,
-    override var finTsServerAddress: String,
+    open var finTsServerAddress: String,
     open var bankName: String,
     open var bic: String,
 
@@ -25,7 +25,7 @@ open class CustomerAccount(
     open var selectedTanMethod: TanMethod? = null,
     open var tanMedia: List<TanMedium> = listOf(),
     open var selectedTanMedium: TanMedium? = null,
-) : CustomerCredentials(bankCode, loginName, password, finTsServerAddress) {
+) : CustomerCredentials(bankCode, loginName, password) {
 
 
     override fun toString(): String {

fints4k/src/commonMain/kotlin/net/dankito/banking/client/model/CustomerCredentials.kt

@@ -4,10 +4,9 @@ package net.dankito.banking.client.model
 open class CustomerCredentials(
     open val bankCode: String,
     open val loginName: String,
-    open val password: String,
+    open val password: String
-    open val finTsServerAddress: String // TODO: get rid of this
 ) {
 
-    internal constructor() : this("", "", "", "") // for object deserializers
+    internal constructor() : this("", "", "") // for object deserializers
 
 }

fints4k/src/commonMain/kotlin/net/dankito/banking/client/model/parameter/FinTsClientParameter.kt

@@ -10,10 +10,9 @@ open class FinTsClientParameter(
   bankCode: String,
   loginName: String,
   password: String,
-  finTsServerAddress: String, // TODO: get rid of this
 
   open val preferredTanMethods: List<TanMethodType>? = null,
   open val preferredTanMedium: String? = null, // the ID of the medium
   open val abortIfTanIsRequired: Boolean = false,
   open val finTsModel: BankData? = null
-) : CustomerCredentials(bankCode, loginName, password, finTsServerAddress)
+) : CustomerCredentials(bankCode, loginName, password)

fints4k/src/commonMain/kotlin/net/dankito/banking/client/model/parameter/GetAccountDataParameter.kt

@@ -10,7 +10,6 @@ open class GetAccountDataParameter(
     bankCode: String,
     loginName: String,
     password: String,
-    finTsServerAddress: String, // TODO: get rid of this
     /**
      * Optionally specify for which bank account to retrieve the account data.
      * If not set the data for all bank accounts of this account will be retrieved.
@@ -25,7 +24,7 @@ open class GetAccountDataParameter(
     preferredTanMedium: String? = null,
     abortIfTanIsRequired: Boolean = false,
     finTsModel: BankData? = null
-) : FinTsClientParameter(bankCode, loginName, password, finTsServerAddress, preferredTanMethods, preferredTanMedium, abortIfTanIsRequired, finTsModel) {
+) : FinTsClientParameter(bankCode, loginName, password, preferredTanMethods, preferredTanMedium, abortIfTanIsRequired, finTsModel) {
 
     open val retrieveOnlyAccountInfo: Boolean
         get() = retrieveBalance == false && retrieveTransactions == RetrieveTransactions.No

fints4k/src/commonMain/kotlin/net/dankito/banking/client/model/response/ErrorCode.kt

@@ -3,6 +3,8 @@ package net.dankito.banking.client.model.response
 
 enum class ErrorCode {
 
+  BankDoesNotSupportFinTs3,
+
   InternalError,
 
   BankReturnedError,

fints4k/src/commonMain/kotlin/net/dankito/banking/fints/FinTsClient.kt

@@ -12,6 +12,7 @@ import net.dankito.banking.fints.response.client.FinTsClientResponse
 import net.dankito.banking.fints.response.client.GetAccountInfoResponse
 import net.dankito.banking.fints.response.client.GetAccountTransactionsResponse
 import net.dankito.banking.fints.response.segments.AccountType
+import net.dankito.banking.fints.util.FinTsServerAddressFinder
 import net.dankito.banking.fints.webclient.IWebClient
 import net.dankito.utils.multiplatform.extensions.minusDays
 import net.dankito.utils.multiplatform.extensions.todayAtEuropeBerlin
@@ -21,6 +22,7 @@ import kotlin.jvm.JvmOverloads
 open class FinTsClient @JvmOverloads constructor(
   open var callback: FinTsClientCallback,
   protected open val jobExecutor: FinTsJobExecutor = FinTsJobExecutor(),
+  protected open val finTsServerAddressFinder: FinTsServerAddressFinder = FinTsServerAddressFinder(),
   protected open val product: ProductData = ProductData("15E53C26816138699C7B6A3E8", "1.0.0") // TODO: get version dynamically
 ) {
 
@@ -29,16 +31,19 @@ open class FinTsClient @JvmOverloads constructor(
   }
 
 
-  constructor(callback: FinTsClientCallback) : this(callback, FinTsJobExecutor()) // Swift does not support default parameter values -> create constructor overloads
+  constructor(callback: FinTsClientCallback, webClient: IWebClient) : this(callback, FinTsJobExecutor(RequestExecutor(webClient = webClient))) // Swift does not support default parameter values -> create constructor overloads
-
-  constructor(callback: FinTsClientCallback, webClient: IWebClient) : this(callback, FinTsJobExecutor(RequestExecutor(webClient = webClient)))
 
 
   protected open val mapper = FinTsModelMapper()
 
 
   open suspend fun getAccountData(param: GetAccountDataParameter): GetAccountDataResponse {
-    val bank = BankData(param.bankCode, param.loginName, param.password, param.finTsServerAddress, "")
+    val finTsServerAddress = finTsServerAddressFinder.findFinTsServerAddress(param.bankCode)
+    if (finTsServerAddress.isNullOrBlank()) {
+      return GetAccountDataResponse(ErrorCode.BankDoesNotSupportFinTs3, "Either bank does not FinTS 3.0 or we don't know its FinTS server address", null, listOf())
+    }
+
+    val bank = BankData(param.bankCode, param.loginName, param.password, finTsServerAddress, "")
     val accounts = param.accounts
 
     if (accounts.isNullOrEmpty() || param.retrieveOnlyAccountInfo) { // then first retrieve customer's bank accounts

fints4k/src/nativeMain/kotlin/Application.kt

@@ -10,22 +10,22 @@ import net.dankito.utils.multiplatform.extensions.*
 import platform.posix.exit
 
 fun main(args: Array<String>) {
-  if (args.size < 4) {
+  if (args.size < 3) {
-    println("Bitte geben Sie Ihre Bankzugangsdaten ein in der Reihenfolge: <Bankleitzahl> <Login name> <Password> <FinTS Serveradresse der Bank>\r\n" +
+    println("Bitte geben Sie Ihre Bankzugangsdaten ein in der Reihenfolge: <Bankleitzahl> <Login name> <Password>\r\n" +
-      "Z. B.: ./fints4k.kexe 10050000 \"Mein Loginname\" GeheimesPasswort \"https://banking-be3.s-fints-pt-be.de/fints30\"")
+      "Z. B.: ./fints4k.kexe 10050000 \"Mein Loginname\" GeheimesPasswort")
     exit(0)
   }
 
-  Application().retrieveAccountData(args[0], args[1], args[2], args[3])
+  Application().retrieveAccountData(args[0], args[1], args[2])
 }
 
 class Application {
 
-  fun retrieveAccountData(bankCode: String, customerId: String, pin: String, finTs3ServerAddress: String) {
+  fun retrieveAccountData(bankCode: String, loginName: String, password: String) {
     runBlocking {
       val client = FinTsClient(SimpleFinTsClientCallback { tanChallenge -> enterTan(tanChallenge) })
 
-      val response = client.getAccountData(GetAccountDataParameter(bankCode, customerId, pin, finTs3ServerAddress))
+      val response = client.getAccountData(GetAccountDataParameter(bankCode, loginName, password))
 
       if (response.error != null) {
         println("An error occurred: ${response.error}${response.errorMessage?.let { " $it" }}")