codinux
/
fints4k
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handling and logging now also dialog end response; logging web request errors

This commit is contained in:
dankl 2019-10-13 18:30:58 +02:00 committed by dankito
parent 19256c8819
commit 8d76ca26d5
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fints4javaLib/src/main/kotlin/net/dankito/fints/FinTsClient.kt
View File

@ -61,7 +61,7 @@ open class FinTsClient(
val dialogEndRequestBody = messageBuilder.createAnonymousDialogEndMessage(bank, dialogData) val dialogEndRequestBody = messageBuilder.createAnonymousDialogEndMessage(bank, dialogData)
getResponseForMessage(dialogEndRequestBody, bank) getAndHandleResponseForMessage(dialogEndRequestBody, bank)
} }
@ -185,14 +185,14 @@ open class FinTsClient(
val dialogEndRequestBody = messageBuilder.createDialogEndMessage(bank, customer, dialogData) val dialogEndRequestBody = messageBuilder.createDialogEndMessage(bank, customer, dialogData)
getResponseForMessage(dialogEndRequestBody, bank) getAndHandleResponseForMessage(dialogEndRequestBody, bank)
} }
protected open fun getAndHandleResponseForMessage(requestBody: String, bank: BankData): Response { protected open fun getAndHandleResponseForMessage(requestBody: String, bank: BankData): Response {
val webResponse = getResponseForMessage(requestBody, bank) val webResponse = getResponseForMessage(requestBody, bank)
return handleResponse(webResponse) return handleResponse(webResponse, bank)
} }
protected open fun getResponseForMessage(requestBody: String, bank: BankData): WebClientResponse { protected open fun getResponseForMessage(requestBody: String, bank: BankData): WebClientResponse {
@ -205,7 +205,7 @@ open class FinTsClient(
) )
} }
protected open fun handleResponse(webResponse: WebClientResponse): Response { protected open fun handleResponse(webResponse: WebClientResponse, bank: BankData): Response {
val responseBody = webResponse.body val responseBody = webResponse.body
if (webResponse.isSuccessful && responseBody != null) { if (webResponse.isSuccessful && responseBody != null) {
@ -216,6 +216,9 @@ open class FinTsClient(
return responseParser.parse(decodedResponse) return responseParser.parse(decodedResponse)
} }
else {
log.error("Request to $bank (${bank.finTs3ServerAddress}) failed", webResponse.error)
}
return Response(false, exception = webResponse.error) return Response(false, exception = webResponse.error)
} }

2
fints4javaLib/src/main/kotlin/net/dankito/fints/model/BankData.kt
View File

@ -25,7 +25,7 @@ open class BankData(
override fun toString(): String { override fun toString(): String {
return bankCode return "$name ($bankCode)"
} }
} }