codinux
/
fints4k
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed catching that if a TAN is required but not entered accountsTransactions is null (even though it shouldn't)

This commit is contained in:
dankito 2021-04-17 19:47:57 +02:00
parent e1e4cbe30a
commit cd15dd01e2
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rest/fints4kRest/src/main/kotlin/net/dankito/banking/fints/rest/mapper/DtoMapper.kt
View File

@ -6,6 +6,7 @@ import net.dankito.banking.fints.response.client.FinTsClientResponse
import net.dankito.banking.fints.response.client.GetTransactionsResponse import net.dankito.banking.fints.response.client.GetTransactionsResponse
import net.dankito.banking.fints.rest.model.dto.response.* import net.dankito.banking.fints.rest.model.dto.response.*
import java.math.BigDecimal import java.math.BigDecimal
import javax.ws.rs.InternalServerErrorException
open class DtoMapper { open class DtoMapper {
@ -37,7 +38,12 @@ open class DtoMapper {
} }
open fun mapTransactions(accountsTransactions: List<GetTransactionsResponse>): GetAccountsTransactionsResponseDto { open fun mapTransactions(accountsTransactions: List<GetTransactionsResponse>?): GetAccountsTransactionsResponseDto {
// TODO: if a TAN is required then accountsTransactions contains null value(s) (but why?) -> application crashes
if (accountsTransactions == null) {
throw InternalServerErrorException("Could not fetch account transactions. Either TAN hasn't been entered or developers made a mistake.")
}
return GetAccountsTransactionsResponseDto(accountsTransactions.map { map(it) }) return GetAccountsTransactionsResponseDto(accountsTransactions.map { map(it) })
} }