codinux
/
fints4k
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Renamed checkIfAccountExists() to addAccount()

This commit is contained in:
dankl 2019-10-30 23:02:59 +01:00 committed by dankito
parent c7e71fcc84
commit f5405f8366
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fints4javaAndroidApp/src/main/java/net/dankito/banking/fints4java/android/ui/MainWindowPresenter.kt
View File

@ -40,7 +40,7 @@ open class MainWindowPresenter(callback: FinTsClientCallback) {
val bank = bankDataMapper.mapFromBankInfo(bankInfo) val bank = bankDataMapper.mapFromBankInfo(bankInfo)
val customer = CustomerData(customerId, pin) val customer = CustomerData(customerId, pin)
finTsClient.checkIfAccountExistsAsync(bank, customer) { response -> finTsClient.addAccountAsync(bank, customer) { response ->
if (response.isSuccessful) { if (response.isSuccessful) {
accounts.put(customer, bank) accounts.put(customer, bank)

2
fints4javaAndroidApp/src/main/java/net/dankito/banking/fints4java/android/ui/dialogs/AddAccountDialog.kt
View File

@ -71,7 +71,7 @@ open class AddAccountDialog : DialogFragment() {
val customerId = edtxtCustomerId.text.toString() val customerId = edtxtCustomerId.text.toString()
val pin = edtxtPin.text.toString() val pin = edtxtPin.text.toString()
presenter.checkIfAccountExists(selectedBank, customerId, pin) { response -> presenter.addAccountAsync(selectedBank, customerId, pin) { response ->
context?.asActivity()?.runOnUiThread { context?.asActivity()?.runOnUiThread {
handleAccountCheckResponseOnUiThread(response) handleAccountCheckResponseOnUiThread(response)
} }

8
fints4javaLib/src/main/kotlin/net/dankito/fints/FinTsClient.kt
View File

@ -111,15 +111,15 @@ open class FinTsClient @JvmOverloads constructor(
} }
open fun checkIfAccountExistsAsync(bank: BankData, customer: CustomerData, open fun addAccountAsync(bank: BankData, customer: CustomerData,
callback: (FinTsClientResponse) -> Unit) { callback: (FinTsClientResponse) -> Unit) {
threadPool.runAsync { threadPool.runAsync {
callback(checkIfAccountExists(bank, customer)) callback(addAccount(bank, customer))
} }
} }
open fun checkIfAccountExists(bank: BankData, customer: CustomerData): FinTsClientResponse { open fun addAccount(bank: BankData, customer: CustomerData): FinTsClientResponse {
val newUserInfoResponse = getBankAndCustomerInfoForNewUser(bank, customer) val newUserInfoResponse = getBankAndCustomerInfoForNewUser(bank, customer)

6
fints4javaLib/src/test/kotlin/net/dankito/fints/FinTsClientTest.kt
View File

@ -76,10 +76,10 @@ class FinTsClientTest {
@Test @Test
fun checkIfAccountExists() { fun addAccount() {
// when // when
val result = underTest.checkIfAccountExists(Bank, Customer) val result = underTest.addAccount(Bank, Customer)
// then // then
assertThat(result.isSuccessful).isTrue() assertThat(result.isSuccessful).isTrue()
@ -136,7 +136,7 @@ class FinTsClientTest {
fun testBankTransfer() { fun testBankTransfer() {
// given // given
underTest.checkIfAccountExists(Bank, Customer) underTest.addAccount(Bank, Customer)
// now IBAN should be set // now IBAN should be set
assertThat(Customer.iban).describedAs("Customer's IBAN should now be set").isNotNull() assertThat(Customer.iban).describedAs("Customer's IBAN should now be set").isNotNull()