Commit Graph

284 Commits

Author SHA1 Message Date
dankito fcde0dcf5b Made order a little bit more logical 2022-02-07 00:18:08 +01:00
dankito 293e8aa849 Also filtering out "9010::Initialisierung fehlgeschlagen, Auftrag nicht bearbeitet." feedbacks, are of now use for user 2022-02-07 00:18:08 +01:00
dankito e4b6a7efd5 If Pin or chipTan is locked only warning but no error is returned by server -> check also these feedbacks to detect if response was successful 2022-02-07 00:18:08 +01:00
dankito df4c8c4a1a Implemented that () returns if a TAN method got selected 2022-02-07 00:18:08 +01:00
dankito eee073fe3b Fixed that if wrong credentials have been entered but bank returned user's TAN methods anyway, GetUserTanMethodsResponse returned success 2022-02-07 00:18:08 +01:00
dankito 269ad0bb33 Mapping accounts named 'Tagesgeld' to Sparkonto as according to Wikipedia some direct banks offer 'Tagesgeldkonten' as a modern version of Sparkonto 2022-02-07 00:18:08 +01:00
dankito 3d3d143023 Added code "0". Even though it's not stated in the docs, but Sparkasse gives some Girokonten the type '0'. 2022-02-07 00:18:08 +01:00
dankito f76603a6ac Fixed that accounts for which types we think we don't support them, but which support to retrieve balance or transactions anyway (e.g. Sparkonten also seem to support HKSAL and HKKAZ, but i can't tell for sure) are now also evaluated as supported 2022-02-07 00:18:08 +01:00
dankito 270f1c6c34 Added upper case diacritics 2022-02-07 00:18:08 +01:00
dankito 318266db0f Fixed that reserved XML characters aren't replaced visibly to user - XML entities would just confuse most users. But XML entities are taking into calculation for max length 2022-02-07 00:18:08 +01:00
dankito 97e7d44a47 Extracted convertReservedXmlCharacters() and convertDiacritics() 2022-02-07 00:18:08 +01:00
dankito bc180f68ab Forgot to commit that closeDialog has been added 2022-02-07 00:18:08 +01:00
dankito 229da4efc8 Calling askUserForTanMethod() instead of selecting user's TAN method automatically 2022-02-07 00:18:08 +01:00
dankito 24dfe34c1f Implemented calling getTanMediaList() only if retrieving TAN media is supported 2022-02-07 00:18:08 +01:00
dankito 63ec9e074a Fixed that getUsersTanMethod() is async but caller had no chance to wait for response 2022-02-07 00:18:08 +01:00
dankito ee38799cad Replaced areWeThatGentleToCloseDialogs by DialogContext.closeDialog 2022-02-07 00:18:08 +01:00
dankito 95736a8150 Removed unused messageMayRequiresTan 2022-02-07 00:18:07 +01:00
dankito f4d8b09260 Added fetchBalanceAndTransactions to addAccount() to determine if balance and transactions should be retrieved after retrieving bank accounts of a newly added account 2022-02-07 00:18:07 +01:00
dankito 9e5b18a522 Renamed initDialog() to initDialogWithStrongCustomerAuthentication() 2022-02-07 00:18:07 +01:00
dankito dd01c7416a Replaced newUserInfoResponse by getAccountsResponse 2022-02-07 00:18:07 +01:00
dankito 75525d704a Also taking now message feedbacks into account to evaluate if wrong credentials have been entered 2022-02-07 00:18:07 +01:00
dankito 38bb0c90ff Implemented detecting if wrong credentials have been entered (not 100 % reliable though) 2022-02-07 00:18:07 +01:00
dankito 69375602e3 Filtering out 'Dialogabbruch' feedbacks 2022-02-07 00:18:07 +01:00
dankito e4aa38e11f Displaying now also response code to user. May she then can help us better (or she may even knows what to do with this information) 2022-02-07 00:18:07 +01:00
dankito 5580313eeb Setting countDaysForWhichTransactionsAreKept now on account and not on bank anymore as the count may differs from account type to account type (e.g. 540 days for checking accounts and 9999 days for credit card accounts) 2022-02-07 00:18:07 +01:00
dankito 6d41b89f1d Implemented parsing credit card transactions parameters 2022-02-07 00:18:07 +01:00
dankito d209bc46fc Renamed haveAllTransactionsBeenFetched to haveAllTransactionsBeenRetrieved and isAccountTypeSupported to isAccountTypeSupportedByApplication 2022-02-07 00:18:07 +01:00
dankito 9854ac000e Little refactoring 2022-02-07 00:18:07 +01:00
dankito b94c5d5cf5 Added toString() 2022-02-07 00:18:07 +01:00
dankito c66f27d88b Fixed parsing the correct amount 2022-02-07 00:18:07 +01:00
dankito bf9d406053 Renamed usage to reference, remittee to recipient and instant payment to real-time transfer 2022-02-07 00:18:07 +01:00
dankito d0910b7180 Parsing now also isCleared 2022-02-07 00:18:07 +01:00
dankito e0dbd00634 Implemented retrieving credit card transactions 2022-02-07 00:18:07 +01:00
dankito d16450d46b Stopping execution now only if a severe error occurred during balance retrieval that closed dialog 2022-02-07 00:18:07 +01:00
dankito c7d6718cce Fixed that if alsoRetrieveBalance is set to false or account doesn't support retrieving balance execution stops here forever and never returns 2022-02-07 00:18:07 +01:00
dankito dee6f4aebe Making use of supportXyz convenience properties 2022-02-07 00:18:07 +01:00
dankito 395ef5445c Fixed that as now retrievedData contains an entry for each account only if account supports retrieving transactions retrieval must be successful 2022-02-07 00:18:07 +01:00
dankito 09d90c6c9d Renamed property accountData to account 2022-02-07 00:18:07 +01:00
dankito 7d8d1eb6d0 Implemented returning default / unsuccessful RetrievedAccountData also for accounts that do not support retrieving transactions or balance 2022-02-07 00:18:07 +01:00
dankito d420cfcfb2 Added convenience properties to determine account features 2022-02-07 00:18:07 +01:00
dankito e973ce256b Added conversion to BigDecimal directly to Amount 2022-02-07 00:18:07 +01:00
dankito b99522fda9 Renamed nameOfTanMediaRequired to nameOfTanMediumRequired 2022-02-07 00:18:07 +01:00
dankito 0efb4ba708 Made supportedFeatures accessible 2022-02-07 00:18:07 +01:00
dankito 1ff2c0ecf3 Renamed messageLogField to messageLog 2022-02-07 00:18:07 +01:00
dankito 50505831ea Removed outdated 'Customer' from method name 2022-02-07 00:18:07 +01:00
dankito f96e7a4b30 Fixed setting ninety days ago to from midnight on so that retrievedTransactionsFromOn gets set correctly -> check in BankingPresenter if all transactions have been fetched also works for this day 2022-02-07 00:18:07 +01:00
dankito 13d95f4bda Implemented storing and displaying for which period account transactions have been fetched 2022-02-07 00:18:07 +01:00
dankito 700e3e6da9 Implemented mapping and displaying if an account type is supported or not 2022-02-07 00:18:07 +01:00
dankito a59b335316 If account type field is not set (as it e.g. comdirect does), trying to extract account type from account name 2022-02-07 00:18:07 +01:00
dankito f5f3f34d3b Renamed TanProcedure to TanMethod in fints4k 2022-02-07 00:18:07 +01:00
dankito 094d669148 Implemented evaluating count days for which bank stores transactions -> don't show fetch all transactions overlay if bank server doesn't store additional transactions 2022-02-07 00:18:07 +01:00
dankito 7a64177d47 Renamed Response to BankResponse 2022-02-07 00:18:07 +01:00
dankito c576673efb Refactored that all internal methods return Response and only public methods return FinTsClientResponse. Fixes bug that when internal methods returned AddAccountResponse successful was false as at this point no account have been added yet 2022-02-07 00:18:07 +01:00
dankito ae56bab18a Fixed updating to new signatures 2022-02-07 00:18:07 +01:00
dankito 129b4f64fa Added account to GetTransactionsParameter 2022-02-07 00:18:07 +01:00
dankito d8739cf193 Renamed isSuccessful to successful 2022-02-07 00:18:07 +01:00
dankito ec3cdb1c39 Added convenience constructor for when an error occurred 2022-02-07 00:18:07 +01:00
dankito 2d4499514a Implemented calculating isSuccessful in AddAccountResponse and GetTransactionsResponse 2022-02-07 00:18:07 +01:00
dankito 044648f569 Calculating supportsRetrievingTransactionsOfLast90DaysWithoutTan now from retrieved data (but try to get rid of it anyway) 2022-02-07 00:18:07 +01:00
dankito 99205b53c9 Removed bankAccount property from GetTransactionsResponse 2022-02-07 00:18:07 +01:00
dankito da5e285d61 Fixed that no Set hasn't been used 2022-02-07 00:18:07 +01:00
dankito 50a5938046 Made all properties overridable 2022-02-07 00:18:07 +01:00
dankito 7cb19d6f7d Extracted RetrievedAccountData, makes code way better readable 2022-02-07 00:18:07 +01:00
dankito 4ae4609ffb Not persisting segmentNumber, referenceSegmentNumber and segmentString. We don't need them after restoring and make resulting JSON file much smaller 2022-02-07 00:18:07 +01:00
dankito f4128a2875 Implemented checking if bank supports setting count max entries. Had to adjust Jackson serialization so that and not just JobParameters gets saved and restored and to implement a lot of default constructors for this 2022-02-07 00:18:07 +01:00
dankito b403557f2d Implemented checking if bank supports setting count max entries. Had to adjust Jackson serialization so that and not just JobParameters gets saved and restored and to implement a lot of default constructors for this 2022-02-07 00:18:07 +01:00
dankito 4ed3d44b9e Implemented parsing retrieve account transactions in MT940 format job parameters 2022-02-07 00:18:07 +01:00
dankito a64e0b9427 Fixed that last allowed job was discarded when extension isn't set 2022-02-07 00:18:07 +01:00
dankito 75399e0664 Implemented logging only if it's really an exception and not a known wrong implementation of FinTS standard 2022-02-07 00:18:07 +01:00
dankito 497b82ce09 Started to implement to remove unnecessary spaces in usage, but now having to few 2022-02-07 00:18:07 +01:00
dankito 0e0a7b5207 Implemented filtering out duplicate transactions as some banks return some transactions multiple times in MT940 response 2022-02-07 00:18:06 +01:00
dankito 0f672f414b Fixed that when entering TAN is required chunkedResponseHandler got called for same handledResponse multiple time, therefore adding e.g. same transactions multiple times to bookedTransactions 2022-02-07 00:18:06 +01:00
dankito 68742cc6a3 Fixed that comparing TanProcedures failed 2022-02-07 00:18:06 +01:00
dankito 50c6a72dff Fixed checking if usage is formatted 2022-02-07 00:18:06 +01:00
dankito f2bbff804d Implemented convenience constructors 2022-02-07 00:18:06 +01:00
dankito e36576e4c6 Added bankCodeForOnlineBanking to make clear that bank code for online banking may differs from bank's bank code 2022-02-07 00:18:06 +01:00
dankito 63259ff404 Merged CustomerData and BankData 2022-02-07 00:18:06 +01:00
dankito 49d34f1733 Removed unused supportsRetrievingTransactionsOfLast90DaysWithoutTan and triedToRetrieveTransactionsOfLast90DaysWithoutTan 2022-02-07 00:18:06 +01:00
dankito 397acebf79 Extracted iOSIsRealDevice so that it's easier to switch between iOS Simulator and real device 2022-02-07 00:18:06 +01:00
dankito 8b1051092a Updated to new method signatures 2022-02-07 00:18:06 +01:00
dankito 2c1c690302 Extracted settings to top of class 2022-02-07 00:18:06 +01:00
dankito dbc30abe2b Moved FinTsClientTestBase back to JVM tests and adjusted to new method signatures 2022-02-07 00:18:06 +01:00
dankito e2199c8494 Generified checking if retrieving user's TAN procedures was successful 2022-02-07 00:18:06 +01:00
dankito 61d9923230 Implemented resetting selected TAN procedures if user's TAN procedures doesn't contain selected one anymore (should almost never be the case) 2022-02-07 00:18:06 +01:00
dankito 73ba48b030 Removed unused BankDataMapper 2022-02-07 00:18:06 +01:00
dankito 458da2a542 Fixed (once again) that Comdirect returns an error when fetching user's TAN procedure with TAN procedure code '999' but returns user's TAN procedures anyway 2022-02-07 00:18:06 +01:00
dankito 2b8c9316d0 Implemented passing Customer to fints4kBankingClient, so that fints4kBankingClient doesn't have a different Customer instance as BankingPresenter 2022-02-07 00:18:06 +01:00
dankito 137d35ac02 Implemented validating and auto correcting user input in TransferMoneyDialog 2022-02-07 00:18:06 +01:00
dankito 321814a0ca Removed exception from Response as this only crashed iOS app. Choosing now on mapper level which message to show in UI 2022-02-07 00:18:06 +01:00
dankito e0c5a72524 MOved FlickerCodeStepsCalculator and Bit to BankingUiCommon 2022-02-07 00:18:06 +01:00
dankito 469e9c9dab Made FlickerCodeStepsCalculator state free 2022-02-07 00:18:06 +01:00
dankito 8b6b12a755 Renamed FlickerCanvas to FlickerCodeStepsCalculator 2022-02-07 00:18:06 +01:00
dankito c8f29e2390 Implemented passing allowed TAN format and max TAN input length to UI so that controls can be set accordingly 2022-02-07 00:18:06 +01:00
dankito 392c473056 Implemented that if retrieving account transactions is not supported but retrieving balances, at least balances get retrieved 2022-02-07 00:18:06 +01:00
dankito c442d02e97 Renamed FinTsMockValue to PinTanDefaultValue 2022-02-07 00:18:06 +01:00
dankito 3160ebaa2c Fixed that GetUserTanProceduresResponse isn't required anymore 2022-02-07 00:18:06 +01:00
dankito 7649df6a6b Fixed that if getting user's TAN procedures fails method didn't stop / still continued 2022-02-07 00:18:06 +01:00
dankito 989bbd65aa Implemented that if a TAN procedure requires specifying TAN media name, that any tan media name gets supplied (in my tests it made absolutely no difference if the TAN media matches the TAN procedure) 2022-02-07 00:18:06 +01:00
dankito 4cbbbfbe48 Implemented initializing dialog without strong customer authentication (but HKTAN is sent anyway) which is required that is essential for authenticated dialogs, e.g. TAN media which require some banks to be able to initialize an authenticated dialog 2022-02-07 00:18:06 +01:00
dankito 7146ec3a3c Fixed that some jobs don't depend that a specific account supports it but the bank itself, e.g. retrieving TAN media 2022-02-07 00:18:06 +01:00